Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Filter searchSchema results based on current search query params #334

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[WIP] Filter searchSchema results based on current search query params #334

wants to merge 10 commits into from

Conversation

zlayne
Copy link
Contributor

@zlayne zlayne commented Feb 13, 2025 •
edited
Loading

Related Issue

https://issues.redhat.com/browse/ACM-17849

Description of changes

  • Added ...

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zlayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zlayne
update tests
09d4d2e 
Signed-off-by: zlayne <[email protected]>
@zlayne
update tests
9685ec5 
Signed-off-by: zlayne <[email protected]>
@zlayne
update tests
23b2d81 
Signed-off-by: zlayne <[email protected]>
@zlayne
add results test
99df06c 
Signed-off-by: zlayne <[email protected]>
@zlayne
Update schema tests
7360dae 
Signed-off-by: zlayne <[email protected]>
@zlayne
Copy link
Contributor Author

zlayne commented Feb 17, 2025

/test sonar-pre-submit

jlpadilla
jlpadilla reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@jlpadilla jlpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but need to confirm that the additional input field won't cause an API break for existing clients.

@zlayne
fix test check
0cb407c 
Signed-off-by: zlayne <[email protected]>
@zlayne
Copy link
Contributor Author

zlayne commented Feb 18, 2025

/test test-unit

@zlayne
Merge branch 'main' into filter-searchschema-results-wiht-existing-qu…
1c86073 
…ery-params

merge main into feature branch
@zlayne
build bump
913313f 
Signed-off-by: zlayne <[email protected]>
@zlayne
undo formatting
75685f5 
Signed-off-by: zlayne <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@zlayne
Copy link
Contributor Author

zlayne commented Feb 19, 2025

/test test-unit

1 similar comment
@zlayne
Copy link
Contributor Author

zlayne commented Feb 19, 2025

/test test-unit

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 19, 2025 •
edited
Loading

@zlayne: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonar-pre-submit 75685f5 link true /test sonar-pre-submit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zlayne
Copy link
Contributor Author

zlayne commented Feb 19, 2025

/test test-unit

@github-actions GitHub Actions
Copy link

This pr has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days (1 week), if no further activity occurs.

@github-actions github-actions bot added the stale label Feb 25, 2025
@zlayne zlayne removed the stale label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlpadilla jlpadilla jlpadilla left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
approved dco-signoff: yes do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlayne @jlpadilla